ui/app_list/views/app_list_view_unittest.cc - Issue 573703003: Make experimental app launcher show 4 rows of apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/app_list_view_unittest.cc

Issue 573703003: Make experimental app launcher show 4 rows of apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dragging_without_grid_resize

Patch Set: ensure centered app list height remains correct when the virtual keyboard is shown Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/app_list_view_unittest.cc

diff --git a/ui/app_list/views/app_list_view_unittest.cc b/ui/app_list/views/app_list_view_unittest.cc

index d1c4fc731afb9d0575aefbcd2759912d9e460113..43dc416c9590b2decd6136e18aae7128c9b36c43 100644

--- a/ui/app_list/views/app_list_view_unittest.cc

+++ b/ui/app_list/views/app_list_view_unittest.cc

@@ -238,6 +238,12 @@ void AppListViewTestContext::RunDisplayTest() {

delegate_->GetTestModel()->PopulateApps(kInitialItems);

Show();

+ // The landscape app launcher needs to be short enough to accomodate the

+ // virtual keyboard.

Matt Giuca 2014/09/16 06:39:39 "... because it is enabled by default when the vir

calamity 2014/09/16 06:55:12 Done.

+ if (test_type_ == LANDSCAPE)

+ EXPECT_GE(403, view_->bounds().height());

if (is_landscape())

EXPECT_EQ(2, GetPaginationModel()->total_pages());

else

« no previous file with comments | « ui/app_list/app_list_constants.cc ('k') | ui/app_list/views/apps_container_view.cc » ('j') | ui/app_list/views/apps_container_view.cc » ('J')