Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 573703003: Make experimental app launcher show 4 rows of apps. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@dragging_without_grid_resize
Project:
chromium
Visibility:
Public.

Description

Make experimental app launcher show 4 rows of apps. This CL changes the number of rows in the experimental app launcher's grid view from 3 to 4. BUG=411775 Committed: https://crrev.com/484f52d63bbf156bd90b639d2f92a8db8c60f6ca Cr-Commit-Position: refs/heads/master@{#295026}

Patch Set 1 #

Patch Set 2 : keep centered app list's grid at 3 rows #

Patch Set 3 : ensure centered app list height remains correct when the virtual keyboard is shown #

Total comments: 4

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M ui/app_list/app_list_constants.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M ui/app_list/views/apps_container_view.cc View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
calamity
6 years, 3 months ago (2014-09-16 05:35:19 UTC) #2
Matt Giuca
lgtm https://codereview.chromium.org/573703003/diff/40001/ui/app_list/views/app_list_view_unittest.cc File ui/app_list/views/app_list_view_unittest.cc (right): https://codereview.chromium.org/573703003/diff/40001/ui/app_list/views/app_list_view_unittest.cc#newcode243 ui/app_list/views/app_list_view_unittest.cc:243: // virtual keyboard. "... because it is enabled ...
6 years, 3 months ago (2014-09-16 06:39:40 UTC) #3
calamity
https://codereview.chromium.org/573703003/diff/40001/ui/app_list/views/app_list_view_unittest.cc File ui/app_list/views/app_list_view_unittest.cc (right): https://codereview.chromium.org/573703003/diff/40001/ui/app_list/views/app_list_view_unittest.cc#newcode243 ui/app_list/views/app_list_view_unittest.cc:243: // virtual keyboard. On 2014/09/16 06:39:39, Matt Giuca wrote: ...
6 years, 3 months ago (2014-09-16 06:55:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573703003/60001
6 years, 3 months ago (2014-09-16 06:56:15 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as edadca895f6c737f41fdc4fa378288ce175e2d6b
6 years, 3 months ago (2014-09-16 07:50:54 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 07:52:29 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/484f52d63bbf156bd90b639d2f92a8db8c60f6ca
Cr-Commit-Position: refs/heads/master@{#295026}

Powered by Google App Engine
This is Rietveld 408576698