Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: src/compiler/instruction-selector.cc

Issue 573703002: Add handling for deopt and argument adaptor frames. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor improvements. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/instruction-selector.cc
diff --git a/src/compiler/instruction-selector.cc b/src/compiler/instruction-selector.cc
index dec46b6af0938013d14e6d7ab555d315e2afd226..a18f1f9082e30afcbd200b31d3c8b0763ad4c118 100644
--- a/src/compiler/instruction-selector.cc
+++ b/src/compiler/instruction-selector.cc
@@ -1037,14 +1037,16 @@ void InstructionSelector::AddFrameStateInputs(
DCHECK_EQ(descriptor->stack_count(), stack->InputCount());
OperandGenerator g(this);
- for (int i = 0; i < descriptor->parameters_count(); i++) {
+ for (size_t i = 0; i < descriptor->parameters_count(); i++) {
inputs->push_back(UseOrImmediate(&g, parameters->InputAt(i)));
}
- inputs->push_back(UseOrImmediate(&g, context));
- for (int i = 0; i < descriptor->locals_count(); i++) {
+ if (descriptor->type() == JS_FRAME) {
Jarin 2014/09/15 13:37:51 How about introducing FrameStateDescriptor::HasCon
sigurds 2014/09/16 08:39:03 Done.
+ inputs->push_back(UseOrImmediate(&g, context));
+ }
+ for (size_t i = 0; i < descriptor->locals_count(); i++) {
inputs->push_back(UseOrImmediate(&g, locals->InputAt(i)));
}
- for (int i = 0; i < descriptor->stack_count(); i++) {
+ for (size_t i = 0; i < descriptor->stack_count(); i++) {
inputs->push_back(UseOrImmediate(&g, stack->InputAt(i)));
}
}

Powered by Google App Engine
This is Rietveld 408576698