Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 573683003: Makes it so we don't start watchdog when running under debugger (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Makes it so we don't start watchdog when running under debugger There is nothing worse than stepping through the debugger and suddenly hitting the watchdog timer DCHECK. If you're running under a debugger seems like you don't care about the watchdog thread. So, make it so we don't start watchdog in this case. BUG=none TEST=none R=rtenneti@chromium.org Committed: https://crrev.com/d9875966d9cf432f2f4cb8ca1d8dda9ee5cec701 Cr-Commit-Position: refs/heads/master@{#297071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sky
6 years, 3 months ago (2014-09-18 18:07:03 UTC) #1
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-09-18 18:09:28 UTC) #2
ramant (doing other things)
On 2014/09/18 18:09:28, ramant wrote: > lgtm Thanks sky, raman
6 years, 3 months ago (2014-09-18 18:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573683003/1
6 years, 3 months ago (2014-09-18 18:12:34 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-18 20:14:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573683003/1
6 years, 2 months ago (2014-09-26 23:08:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9c94c89487677dab6447327c54509dc238ae1131
6 years, 2 months ago (2014-09-26 23:35:48 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 23:36:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9875966d9cf432f2f4cb8ca1d8dda9ee5cec701
Cr-Commit-Position: refs/heads/master@{#297071}

Powered by Google App Engine
This is Rietveld 408576698