Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 573673002: WebRTC: Pin SDK version to 10.9 for Mac and iOS. (Closed)

Created:
4 years, 9 months ago by kjellander_chromium
Modified:
4 years, 9 months ago
Reviewers:
agable
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

WebRTC: Pin SDK version to 10.9 for Mac and iOS. Recent changes in WebRTC have introduced dependencies on the AVFoundation library, which is not accessible in the default SDK (which is still 10.6). Setting SDK to 10.7 would be enough to fix this particular issue, but our engineers would rather want to pin to 10.9 to ensure we catch problems earlier on (see referenced bug for discussion). BUG=webrtc:3120 TESTED=Local builds setting mac_sdk=10.9 for Mac and iOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291964

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_10_6_memcheck.json View 1 chunk +1 line, -1 line 3 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_10_6_tsan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_release__large_tests_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_rel.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
https://codereview.chromium.org/573673002/diff/1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_10_6_memcheck.json File scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_10_6_memcheck.json (right): https://codereview.chromium.org/573673002/diff/1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_10_6_memcheck.json#newcode2 scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac_10_6_memcheck.json:2: { I haven't tested these old 10.6 bots, but ...
4 years, 9 months ago (2014-09-15 07:47:04 UTC) #2
agable
lgtm, but I think it would be good to delete the obviously broken bots at ...
4 years, 9 months ago (2014-09-15 09:03:00 UTC) #3
kjellander_chromium
I'm removing those bots in https://codereview.chromium.org/573693002/ - better to keep those CLs separate. Will file ...
4 years, 9 months ago (2014-09-15 10:03:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573673002/1
4 years, 9 months ago (2014-09-15 10:03:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2014-09-15 10:04:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 291964

Powered by Google App Engine
This is Rietveld 408576698