Credential Manager: Wire up the client.

Source/modules/credentialmanager/CredentialManagerClient.h

Index: Source/modules/credentialmanager/CredentialManagerClient.h
diff --git a/Source/modules/credentialmanager/CredentialManagerClient.h b/Source/modules/credentialmanager/CredentialManagerClient.h
index 4cc652c4e6261d5386f9182cccd65e3c9188a158..a53dc57179b906a642dad7dc55c90bb9361cc50f 100644
--- a/Source/modules/credentialmanager/CredentialManagerClient.h
+++ b/Source/modules/credentialmanager/CredentialManagerClient.h
@@ -13,6 +13,7 @@ namespace blink {
 
 class KURL;
 class Page;
+class ScriptState;
 class WebCredential;
 class WebURL;
 
@@ -26,6 +27,7 @@ public:
 
     static const char* supplementName();
     static CredentialManagerClient* from(Page*);
+    static CredentialManagerClient* from(ScriptState*);

[sof, 2014/09/15 07:57:17]

I think I would prefer it if we kept this free of ScriptState*, using
ExecutionContext* instead (same goes for canAccessCredentialManagerAPI())

[Mike West, 2014/09/16 07:53:20]

How about we compromise, and keep ScriptState out of public APIs? Since
`canAccessCredentialManagerAPI` is an internal implementation detail of
CredentialsContainer, changing it to use ExecutionContext* would just mean that
I call the `executionContext()` getter in more places. I'm not sure that gains
us any clarity.

[Mike West, 2014/09/16 07:53:20]

Eh. Ended up rewriting most of this anyway. :)

[sof, 2014/09/16 12:36:11]

thanks, that works for me

 
     // Ownership of the callback is transferred to the callee for each of
     // the following methods.