Credential Manager: Wire up the client.

Source/modules/credentialmanager/CredentialManagerClient.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/credentialmanager/CredentialManagerClient.h"
 
+#include "bindings/core/v8/ScriptState.h"
+#include "core/dom/Document.h"
+#include "core/dom/ExecutionContext.h"
 #include "core/page/Page.h"
 
 namespace blink {
 
 CredentialManagerClient::CredentialManagerClient(WebCredentialManagerClient* client)
     : m_client(client)
 {
 }
 
 CredentialManagerClient::~CredentialManagerClient()
 {
 }
 
 // static
 const char* CredentialManagerClient::supplementName()
 {
     return "CredentialManagerClient";
 }
 
 // static
+CredentialManagerClient* CredentialManagerClient::from(ScriptState* scriptState)
+{
+    if (!scriptState->executionContext()->isDocument())
+        return 0;
+    return from(toDocument(scriptState->executionContext())->page());

[sof, 2014/09/15 07:57:17]

If the document has become detached, page() will be 0 -- add a null check?

[Mike West, 2014/09/16 07:53:20]

That's taken care of in `Supplementable::from()`: it will return 0 rather than a
CredentialManagerClient.

[sof, 2014/09/16 12:36:11]

It does (but a bit tight); I won't insist.

+}
+
+// static
 CredentialManagerClient* CredentialManagerClient::from(Page* page)
 {
     return static_cast<CredentialManagerClient*>(WillBeHeapSupplement<Page>::from(page, supplementName()));
 }
 
 void provideCredentialManagerClientTo(Page& page, CredentialManagerClient* client)
 {
     CredentialManagerClient::provideTo(page, CredentialManagerClient::supplementName(), adoptPtrWillBeNoop(client));
 }
 
@@ skipping 19 matching lines @@
 }
 
 void CredentialManagerClient::dispatchRequest(bool zeroClickOnly, const WebVector<WebURL>& federations, WebCredentialManagerClient::RequestCallbacks* callbacks)
 {
     if (!m_client)
         return;
     m_client->dispatchRequest(zeroClickOnly, federations, callbacks);
 }
 
 } // namespace blink