[Chrome Shell]Added code to regain focus on selection of any item from options menu.

[Chrome Shell]Added code to regain focus on selection of any item from options menu.

Currently if some option is selected from options menu then in that
case content view does not gain focus in operations(like prev,next ).
Added code to handle this.

BUG=414219
Committed: https://crrev.com/b6e03f482bd0521fe299bf51873124d178b880a9
Cr-Commit-Position: refs/heads/master@{#295661}

[ankit, 2014-09-15 13:44:35]

ankit2.kumar@samsung.com changed reviewers:
+ bauerb@chromium.org, tedchoc@chromium.org

[ankit, 2014-09-15 13:44:36]

@Bernhard, @Ted
PTAL

[Bernhard Bauer, 2014-09-15 13:52:56]

Note that this CL fixes the linked issue only for ChromeShell, not for Chrome.

https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
(right):

https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java:296:
if (activeTab != null && containerView.isFocusable()
You are accessing |activeTab| on the previous line. If it were null, you would
have crashed by now.

[ankit, 2014-09-15 14:19:51]

@Bernhard
PTAL new patch 
I am assuming that I am not having permission for files related to chrome.
Please let me know if is it possible for me to fix this bug for chrome also.

https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
(right):

https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java:296:
if (activeTab != null && containerView.isFocusable()
On 2014/09/15 13:52:56, Bernhard Bauer wrote:
> You are accessing |activeTab| on the previous line. If it were null, you would
> have crashed by now.

Sorry for such mistake.

[Bernhard Bauer, 2014-09-15 14:32:54]

On 2014/09/15 14:19:51, ankit wrote:
> @Bernhard
> PTAL new patch 
> I am assuming that I am not having permission for files related to chrome.
> Please let me know if is it possible for me to fix this bug for chrome also.

No, right now that code is not public. You can mark this CL with [ChromeShell]
though to make it more clear.

> 
>
https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
> (right):
> 
>
https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java:296:
> if (activeTab != null && containerView.isFocusable()
> On 2014/09/15 13:52:56, Bernhard Bauer wrote:
> > You are accessing |activeTab| on the previous line. If it were null, you
would
> > have crashed by now.
> 
> Sorry for such mistake.

[ankit, 2014-09-15 15:29:40]

On 2014/09/15 14:32:54, Bernhard Bauer wrote:
> On 2014/09/15 14:19:51, ankit wrote:
> > @Bernhard
> > PTAL new patch 
> > I am assuming that I am not having permission for files related to chrome.
> > Please let me know if is it possible for me to fix this bug for chrome also.
> 
> No, right now that code is not public. You can mark this CL with [ChromeShell]
> though to make it more clear.
> 
> > 
> >
>
https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
> > File
> >
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/573653003/diff/1/chrome/android/shell/java/sr...
> >
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java:296:
> > if (activeTab != null && containerView.isFocusable()
> > On 2014/09/15 13:52:56, Bernhard Bauer wrote:
> > > You are accessing |activeTab| on the previous line. If it were null, you
> would
> > > have crashed by now.
> > 
> > Sorry for such mistake.

@Bernhard
I have updated Description and subject as suggested.

[Bernhard Bauer, 2014-09-15 16:47:00]

LGTM, but I'd like for Ted to have a look as well.

[ankit, 2014-09-15 17:14:17]

On 2014/09/15 16:47:00, Bernhard Bauer wrote:
> LGTM, but I'd like for Ted to have a look as well.

@Ted
PTAL

[ankit, 2014-09-18 03:42:55]

On 2014/09/15 17:14:17, ankit wrote:
> On 2014/09/15 16:47:00, Bernhard Bauer wrote:
> > LGTM, but I'd like for Ted to have a look as well.
> 
> @Ted
> PTAL

@Ted
PTAL

[Ted C, 2014-09-18 16:54:20]

On 2014/09/18 03:42:55, ankit wrote:
> On 2014/09/15 17:14:17, ankit wrote:
> > On 2014/09/15 16:47:00, Bernhard Bauer wrote:
> > > LGTM, but I'd like for Ted to have a look as well.
> > 
> > @Ted
> > PTAL
> 
> @Ted
> PTAL

lgtm -- will revisit if the bug gets updated by UX.

[Ted C, 2014-09-18 16:54:20]

On 2014/09/18 03:42:55, ankit wrote:
> On 2014/09/15 17:14:17, ankit wrote:
> > On 2014/09/15 16:47:00, Bernhard Bauer wrote:
> > > LGTM, but I'd like for Ted to have a look as well.
> > 
> > @Ted
> > PTAL
> 
> @Ted
> PTAL

lgtm -- will revisit if the bug gets updated by UX.

[ankit, 2014-09-19 03:37:16]

On 2014/09/18 16:54:20, Ted C wrote:
> On 2014/09/18 03:42:55, ankit wrote:
> > On 2014/09/15 17:14:17, ankit wrote:
> > > On 2014/09/15 16:47:00, Bernhard Bauer wrote:
> > > > LGTM, but I'd like for Ted to have a look as well.
> > > 
> > > @Ted
> > > PTAL
> > 
> > @Ted
> > PTAL
> 
> lgtm -- will revisit if the bug gets updated by UX.

Thanks

[ankit, 2014-09-19 03:37:21]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-09-19 03:38:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/573653003/20001

[commit-bot: I haz the power, 2014-09-19 04:33:51]

Committed patchset #2 (id:20001) as 9ba93d109dec7fb234f7c306374ef1d785aaad05

[commit-bot: I haz the power, 2014-09-19 04:34:26]

Patchset 2 (id:??) landed as
https://crrev.com/b6e03f482bd0521fe299bf51873124d178b880a9
Cr-Commit-Position: refs/heads/master@{#295661}