Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 573623003: Use a more suitable storage for the timezone table. (Closed)

Created:
6 years, 3 months ago by Daniel Bratell
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use a more suitable storage for the timezone table. Creating a runtime table of std::string objects, just to copy those into a map, is not optimal from a runtime or footprint point of view. Making the table use raw char pointers shrinks the code and data by 75%, from 36 KB to 10 KB (clang, Linux, 64 bit content_shell). clang: Total change: -27266 bytes ========================== 2 added, totalling +8448 bytes across 1 sources 774 removed, totalling -36401 bytes across 2 sources 1 grown, for a net change of +687 bytes (481 bytes before, 1168 bytes after) across 1 sources R=estade@chromium.org,mark@chromium.org BUG= Committed: https://crrev.com/68f667d7c49c3c09cb084dd2739ce5445130464d Cr-Commit-Position: refs/heads/master@{#297821}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Timezone #

Patch Set 3 : TimeZone - with const comparator. #

Patch Set 4 : TimeZone: iterator type #

Total comments: 4

Patch Set 5 : Timezone: Now with an extra empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M base/i18n/timezone.cc View 1 2 3 4 5 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
Daniel Bratell
jshin, could you please take a look at this change from std::string to const char* ...
6 years, 3 months ago (2014-09-15 11:01:08 UTC) #2
Evan Stade
sweet, lgtm (I'm not an owner though)
6 years, 3 months ago (2014-09-15 17:14:56 UTC) #3
Evan Stade
ping jshin
6 years, 2 months ago (2014-09-25 00:05:34 UTC) #4
Mark Mentovai
At the very least, I think the “value” side of the map should change to ...
6 years, 2 months ago (2014-10-01 13:05:07 UTC) #6
Daniel Bratell
Switched to full const char* -> const char*. It cost ~1 KB in a new ...
6 years, 2 months ago (2014-10-01 19:56:23 UTC) #7
Mark Mentovai
LGTM. Nice. https://codereview.chromium.org/573623003/diff/60001/base/i18n/timezone.cc File base/i18n/timezone.cc (right): https://codereview.chromium.org/573623003/diff/60001/base/i18n/timezone.cc#newcode8 base/i18n/timezone.cc:8: #include <map> Chrome code puts a blank ...
6 years, 2 months ago (2014-10-01 20:03:52 UTC) #8
Daniel Bratell
https://codereview.chromium.org/573623003/diff/60001/base/i18n/timezone.cc File base/i18n/timezone.cc (right): https://codereview.chromium.org/573623003/diff/60001/base/i18n/timezone.cc#newcode8 base/i18n/timezone.cc:8: #include <map> On 2014/10/01 20:03:52, Mark Mentovai wrote: > ...
6 years, 2 months ago (2014-10-02 06:23:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573623003/80001
6 years, 2 months ago (2014-10-02 06:25:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573623003/80001
6 years, 2 months ago (2014-10-02 06:28:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14907)
6 years, 2 months ago (2014-10-02 06:35:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573623003/80001
6 years, 2 months ago (2014-10-02 08:44:39 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/4215)
6 years, 2 months ago (2014-10-02 08:50:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573623003/80001
6 years, 2 months ago (2014-10-02 09:03:46 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/4221)
6 years, 2 months ago (2014-10-02 09:12:35 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573623003/80001
6 years, 2 months ago (2014-10-02 13:01:59 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001) as dee1aeb60afa4a078a0719d9e5c2c8b2273f87f4
6 years, 2 months ago (2014-10-02 13:16:49 UTC) #26
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 13:17:28 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/68f667d7c49c3c09cb084dd2739ce5445130464d
Cr-Commit-Position: refs/heads/master@{#297821}

Powered by Google App Engine
This is Rietveld 408576698