Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 573623002: Code refactor related to WeakPtrFactory in src/components module (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Code refactor related to WeakPtrFactory in src/components module Changing in the intialization order of WeakPtrFactory in src/components module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/59b968271f2a2fb948ad110f0ed1b3da870b0eb5 Cr-Commit-Position: refs/heads/master@{#295084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/metrics/net/network_metrics_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_cache/browser/web_cache_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anujsharma
6 years, 3 months ago (2014-09-15 05:40:37 UTC) #2
anujsharma
On 2014/09/15 05:40:37, anujsharma wrote: PTAL
6 years, 3 months ago (2014-09-15 05:43:23 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-16 15:45:29 UTC) #4
anujsharma
On 2014/09/16 15:45:29, jochen wrote: > lgtm Thanks for lgtm jochen.
6 years, 3 months ago (2014-09-16 15:57:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573623002/1
6 years, 3 months ago (2014-09-16 15:58:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0ff6d704c3c627292507290cfdb959bdd642c327
6 years, 3 months ago (2014-09-16 16:53:23 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:54:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59b968271f2a2fb948ad110f0ed1b3da870b0eb5
Cr-Commit-Position: refs/heads/master@{#295084}

Powered by Google App Engine
This is Rietveld 408576698