Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: src/spaces.h

Issue 5736008: Provide baseline for experimental GC implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/globals.h ('K') | « src/objects-inl.h ('k') | src/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces.h
diff --git a/src/spaces.h b/src/spaces.h
index a1f0c6b01155e40d82b44389cd859fafbb3b7ea9..e691dfab9f7ea30b52af344f72ea9b1c758459ad 100644
--- a/src/spaces.h
+++ b/src/spaces.h
@@ -2063,24 +2063,18 @@ class MapSpace : public FixedSpace {
MapSpace(intptr_t max_capacity, int max_map_space_pages, AllocationSpace id)
: FixedSpace(max_capacity, id, Map::kSize, "map"),
max_map_space_pages_(max_map_space_pages) {
- ASSERT(max_map_space_pages < kMaxMapPageIndex);
}
// Prepares for a mark-compact GC.
virtual void PrepareForMarkCompact(bool will_compact);
// Given an index, returns the page address.
- Address PageAddress(int page_index) { return page_addresses_[page_index]; }
-
- static const int kMaxMapPageIndex = 1 << MapWord::kMapPageIndexBits;
+ // TODO(gc): this limit is artifical just to keep code compilable
+ static const int kMaxMapPageIndex = 1 << 16;
// Are map pointers encodable into map word?
bool MapPointersEncodable() {
- if (!FLAG_use_big_map_space) {
- ASSERT(CountPagesToTop() <= kMaxMapPageIndex);
- return true;
- }
- return CountPagesToTop() <= max_map_space_pages_;
+ return false;
}
// Should be called after forced sweep to find out if map space needs
@@ -2151,9 +2145,6 @@ class MapSpace : public FixedSpace {
const int max_map_space_pages_;
- // An array of page start address in a map space.
- Address page_addresses_[kMaxMapPageIndex];
-
public:
TRACK_MEMORY("MapSpace")
};
« src/globals.h ('K') | « src/objects-inl.h ('k') | src/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698