Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 573573003: Revert of Introduce GetBackendFromContextId to avoid using list index. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
achuithb, tonyg, tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/556003005/) Reason for revert: It looks like the moto E perf bots are broken due to this change. BUG=414267 Original issue's description: > Introduce GetBackendFromContextId to avoid using list index. > > BUG=398467 > TEST=ExtensionTest > > Committed: https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc > Cr-Commit-Position: refs/heads/master@{#294455} TBR=tbarzic@chromium.org,achuith@chromium.org NOTREECHECKS=true NOTRY=true BUG=398467 Committed: https://crrev.com/c8fad04c1e2119f9e8efc68f32d5268161d044d3 Cr-Commit-Position: refs/heads/master@{#295136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/extension_backend.py View 1 chunk +7 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nednguyen
Created Revert of Introduce GetBackendFromContextId to avoid using list index.
6 years, 3 months ago (2014-09-16 01:29:45 UTC) #1
achuithb
On 2014/09/16 01:29:45, nednguyen wrote: > Created Revert of Introduce GetBackendFromContextId to avoid using list ...
6 years, 3 months ago (2014-09-16 20:05:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573573003/1
6 years, 3 months ago (2014-09-16 20:21:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as a37b3543311584951f98f2ca710ba4f9116e17fb
6 years, 3 months ago (2014-09-16 20:22:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8fad04c1e2119f9e8efc68f32d5268161d044d3 Cr-Commit-Position: refs/heads/master@{#295136}
6 years, 3 months ago (2014-09-16 20:22:41 UTC) #9
nednguyen
6 years, 3 months ago (2014-09-17 01:10:50 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/578693002/ by nednguyen@google.com.

The reason for reverting is: Revert the revert since the bot is still red after
the revert..

Powered by Google App Engine
This is Rietveld 408576698