Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4026)

Unified Diff: chrome/browser/history/in_memory_url_index.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/in_memory_url_index.h
diff --git a/chrome/browser/history/in_memory_url_index.h b/chrome/browser/history/in_memory_url_index.h
index f7806c344620ab7ddfc38621e50002998ca9ae22..abdef5aefc46c411032e1292a6bfedf4f5640560 100644
--- a/chrome/browser/history/in_memory_url_index.h
+++ b/chrome/browser/history/in_memory_url_index.h
@@ -16,6 +16,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
+#include "base/scoped_observer.h"
#include "base/strings/string16.h"
#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/history/history_db_task.h"
@@ -245,6 +246,7 @@ class InMemoryURLIndex : public HistoryServiceObserver,
const URLRow& row,
const RedirectList& redirects,
base::Time visit_time) override;
+ virtual void OnHistoryServiceLoaded(HistoryService* history_service) override;
sdefresne 2014/10/30 17:37:03 style: Chromium style changed so that virtual meth
nshaik 2014/10/30 21:48:35 Done.
// Notification handlers.
void OnURLsModified(const URLsModifiedDetails* details);
@@ -309,6 +311,9 @@ class InMemoryURLIndex : public HistoryServiceObserver,
// index has been destructed.
bool needs_to_be_cached_;
+ ScopedObserver<HistoryService, HistoryServiceObserver>
+ history_service_observer_;
+
DISALLOW_COPY_AND_ASSIGN(InMemoryURLIndex);
};

Powered by Google App Engine
This is Rietveld 408576698