Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: chrome/browser/history/history_service.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ScopedObserver to InMemoryHistoryBackend,PrerenderLocalPredictor,ChromeTemplateURLServiceClient Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 91b4bfcda6e7ad0b2441207375ce6cca560cb8b2..267e82eca125117bed54288e60f4107a4ecb70e3 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -53,6 +53,10 @@ class FilePath;
class Thread;
}
+namespace safe_browsing {
+class LastDownloadFinder;
+}
+
namespace visitedlink {
class VisitedLinkMaster;
}
@@ -539,8 +543,10 @@ class HistoryService : public content::NotificationObserver,
friend class HistoryURLProviderTest;
friend class history::InMemoryURLIndexTest;
template<typename Info, typename Callback> friend class DownloadRequest;
+ friend class safe_browsing::LastDownloadFinder;
friend class PageUsageRequest;
friend class RedirectRequest;
+ friend class SyncBookmarkDataTypeControllerTest;
friend class TestingProfile;
// Called on shutdown, this will tell the history backend to complete and
@@ -607,6 +613,13 @@ class HistoryService : public content::NotificationObserver,
// modified. |changed_urls| contains the list of affects URLs.
void NotifyURLsModified(const history::URLRows& changed_urls);
+ // Notify all HistoryServiceObservers registered that the
+ // HistoryService has finished loading.
+ void NotifyHistoryServiceLoaded();
+
+ // HistoryService is being deleted.
+ void NotifyHistoryServiceBeingDeleted();
+
// Favicon -------------------------------------------------------------------
// These favicon methods are exposed to the FaviconService. Instead of calling
@@ -845,6 +858,9 @@ class HistoryService : public content::NotificationObserver,
a, b, c, d, e));
}
+ // TODO(sdefresne): http://crbug.com/430070 remove this method.
+ Profile* profile() { return profile_; }
+
base::ThreadChecker thread_checker_;
content::NotificationRegistrar registrar_;

Powered by Google App Engine
This is Rietveld 408576698