Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/browser/predictors/autocomplete_action_predictor.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/autocomplete_action_predictor.h
diff --git a/chrome/browser/predictors/autocomplete_action_predictor.h b/chrome/browser/predictors/autocomplete_action_predictor.h
index a41c5a85b4013eb43725c1cdc2f417f3c2f1ce5b..984ba218bbf4e35e7ba10dc734243f54f66f56a3 100644
--- a/chrome/browser/predictors/autocomplete_action_predictor.h
+++ b/chrome/browser/predictors/autocomplete_action_predictor.h
@@ -14,6 +14,7 @@
#include "base/strings/string16.h"
#include "chrome/browser/history/history_types.h"
#include "chrome/browser/predictors/autocomplete_action_predictor_table.h"
+#include "components/history/core/browser/history_service_observer.h"
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/notification_observer.h"
@@ -61,6 +62,7 @@ namespace predictors {
class AutocompleteActionPredictor
: public KeyedService,
public content::NotificationObserver,
+ public history::HistoryServiceObserver,
public base::SupportsWeakPtr<AutocompleteActionPredictor> {
public:
enum Action {
@@ -112,6 +114,9 @@ class AutocompleteActionPredictor
// abandoned.
bool IsPrerenderAbandonedForTesting();
+ // Is called when |service| is loaded.
sdefresne 2014/10/20 13:15:42 // historyHistoryServiceObserver:
+ virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;
sdefresne 2014/10/20 13:15:42 OVERRIDE -> override
+
private:
friend class AutocompleteActionPredictorTest;
friend class ::PredictorsHandler;

Powered by Google App Engine
This is Rietveld 408576698