Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/browser/history/history_service.h

Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 6b3d3e74e308315f5911d0b105cad194ff4bcdb5..b45dd102060eb857808cd12b9f99779a423dd170 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -26,6 +26,7 @@
 #include "chrome/common/ref_counted_util.h"
 #include "components/favicon_base/favicon_callback.h"
 #include "components/history/core/browser/history_client.h"
+#include "components/history/core/browser/history_service_observer.h"
 #include "components/history/core/browser/keyword_id.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/visitedlink/browser/visitedlink_delegate.h"
@@ -512,6 +513,14 @@ class HistoryService : public content::NotificationObserver,
       const tracked_objects::Location& from_here,
       const syncer::SyncChangeList& change_list) OVERRIDE;
 
+  // Adds or removes observers for the HistoryServiceObserver.
+  void AddHistoryServiceObserver(history::HistoryServiceObserver* observer);
+  void RemoveHistoryServiceObserver(history::HistoryServiceObserver* observer);
+  // Called to Notify the HistoryService is loaded.
+  void NotifyHistoryServiceLoaded();
+  // Returns Profile that the history service belongs to.
+  Profile* profile() { return profile_; }

[sdefresne, 2014/09/23 08:45:09]

We'll have to remove this method later. Can you make it private and add
LastDownloadFinder as a friend class, so that no new client is added for it,
with a comment?
 // TODO(sdefresne): remove this method

[nshaik, 2014/10/29 08:43:39]

Done.

+
  protected:
   // These are not currently used, hopefully we can do something in the future
   // to ensure that the most important things happen first.
@@ -868,6 +877,8 @@ class HistoryService : public content::NotificationObserver,
 
   history::DeleteDirectiveHandler delete_directive_handler_;
 
+  ObserverList<history::HistoryServiceObserver> history_service_observers_;
+
   DISALLOW_COPY_AND_ASSIGN(HistoryService);
 };