chrome/browser/search_engines/chrome_template_url_service_client.h - Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/search_engines/chrome_template_url_service_client.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ScopedObserver to InMemoryHistoryBackend,PrerenderLocalPredictor,ChromeTemplateURLServiceClient Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chrome_notification_types.h ('K') | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc ('k') | chrome/browser/search_engines/chrome_template_url_service_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_	5 #ifndef CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_

6 #define CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_	6 #define CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_

7	7

	8 #include "base/scoped_observer.h"

8 #include "components/history/core/browser/history_service_observer.h"	9 #include "components/history/core/browser/history_service_observer.h"

9 #include "components/search_engines/template_url_service_client.h"	10 #include "components/search_engines/template_url_service_client.h"

10	11

11 class HistoryService;	12 class HistoryService;

12	13

13 // ChromeTemplateURLServiceClient provides keyword related history	14 // ChromeTemplateURLServiceClient provides keyword related history

14 // functionality for TemplateURLService.	15 // functionality for TemplateURLService.

15 class ChromeTemplateURLServiceClient : public TemplateURLServiceClient,	16 class ChromeTemplateURLServiceClient : public TemplateURLServiceClient,

16 public history::HistoryServiceObserver {	17 public history::HistoryServiceObserver {

17 public:	18 public:

(...skipping 12 matching lines...) Expand all Loading...
30	31

31 // history::HistoryServiceObserver:	32 // history::HistoryServiceObserver:

32 void OnURLVisited(HistoryService* history_service,	33 void OnURLVisited(HistoryService* history_service,

33 ui::PageTransition transition,	34 ui::PageTransition transition,

34 const history::URLRow& row,	35 const history::URLRow& row,

35 const history::RedirectList& redirects,	36 const history::RedirectList& redirects,

36 base::Time visit_time) override;	37 base::Time visit_time) override;

37	38

38 private:	39 private:

39 TemplateURLService* owner_;	40 TemplateURLService* owner_;

	41 ScopedObserver<HistoryService, HistoryServiceObserver>

	42 history_service_observer_;

40 HistoryService* history_service_;	43 HistoryService* history_service_;

41	44

42 DISALLOW_COPY_AND_ASSIGN(ChromeTemplateURLServiceClient);	45 DISALLOW_COPY_AND_ASSIGN(ChromeTemplateURLServiceClient);

43 };	46 };

44	47

45 #endif // CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_	48 #endif // CHROME_BROWSER_SEARCH_ENGINES_CHROME_TEMPLATE_URL_SERVICE_CLIENT_H_

OLD	NEW