PDF Viewer - PageUp/Down don't move pdf by page size in FitToPage mode

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 2408 matching lines @@
   int32 doc_height = static_cast<int>(document_size_.height() * zoom_);
   pp::Point origin(
       plugin_size_.width() - page_indicator_.rect().width() -
           GetScaled(GetScrollbarReservedThickness()),
       page_indicator_.GetYPosition(engine_->GetVerticalScrollbarYPosition(),
                                    doc_height, plugin_size_.height()));
   page_indicator_.MoveTo(origin, invalidate);
 }
 
 void Instance::SetZoom(ZoomMode zoom_mode, double scale) {
+  // If same zoom level, don't do anything.

[wjmaclean, 2014/10/08 14:14:33]

You might modify this comment to indicate that, in particular, we avoid changing
the zoom_mode value if the scale is the same.

[raymes, 2014/10/08 17:23:55]

// If the zoom level doesn't change it means that this zoom change might have
been initiated by
// the plugin. In that case we don't want to change the zoom mode to ZOOM_SCALE
as it may have
// been intentionally set to ZOOM_FIT_TO_PAGE or some other value when the zoom
was last changed.

[Nikhil, 2014/10/09 06:36:19]

Done.

+  if (scale == zoom_)
+    return;
+
   double old_zoom = zoom_;
 
   zoom_mode_ = zoom_mode;
   if (zoom_mode_ == ZOOM_SCALE)
     zoom_ = scale;
   UpdateZoomScale();
 
   engine_->ZoomUpdated(zoom_ * device_scale_);
   OnGeometryChanged(old_zoom, device_scale_);
 
@@ skipping 300 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf