PDF Viewer - PageUp/Down don't move pdf by page size in FitToPage mode

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 491 matching lines @@
     return true;
 
   // Left/Right arrows should scroll to the beginning of the Prev/Next page if
   // there is no horizontal scroll bar.
   // If fit-to-height, PgDown/PgUp should scroll to the beginning of the
   // Prev/Next page. Spacebar / shift+spacebar should do the same.
   if (v_scrollbar_.get() && event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN) {
     pp::KeyboardInputEvent keyboard_event(event);
     bool no_h_scrollbar = !h_scrollbar_.get();
     uint32_t key_code = keyboard_event.GetKeyCode();
-    bool page_down = no_h_scrollbar && key_code == ui::VKEY_RIGHT;
-    bool page_up = no_h_scrollbar && key_code == ui::VKEY_LEFT;
+    // Page down is ui::VKEY_NEXT.
+    bool page_down = no_h_scrollbar &&
+                     (key_code == ui::VKEY_RIGHT || key_code == ui::VKEY_NEXT);
+    // Page up is ui::VKEY_PRIOR.
+    bool page_up = no_h_scrollbar &&
+                   (key_code == ui::VKEY_LEFT || key_code == ui::VKEY_PRIOR);
     if (zoom_mode_ == ZOOM_FIT_TO_PAGE) {
       bool has_shift =
           keyboard_event.GetModifiers() & PP_INPUTEVENT_MODIFIER_SHIFTKEY;
       bool key_is_space = key_code == ui::VKEY_SPACE;
       page_down |= key_is_space || key_code == ui::VKEY_NEXT;

[raymes, 2014/09/15 00:12:14]

But it should get set here when in ZOOM_FIT_TO_PAGE, right?

[Nikhil, 2014/09/16 10:23:29]

Acknowledged.

       page_up |= (key_is_space && has_shift) || (key_code == ui::VKEY_PRIOR);
     }
     if (page_down) {
       int page = engine_->GetFirstVisiblePage();
       // Engine calculates visible page including delimiter to the page size.
       // We need to check here if the page itself is completely out of view and
       // scroll to the next one in that case.
       if (engine_->GetPageRect(page).bottom() * zoom_ <=
           v_scrollbar_->GetValue())
         page++;
@@ skipping 2210 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf