Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 573513002: Fix WeakPtrFactory member placement. (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member placement. Changing in the intialization order of WeakPtrFactory in src/extensions module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/bb1951228bfc4c44e649f00d9a42c3d142a7227f Cr-Commit-Position: refs/heads/master@{#294743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M extensions/browser/guest_view/web_view/web_view_find_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anujsharma
6 years, 3 months ago (2014-09-13 10:44:12 UTC) #2
anujsharma
On 2014/09/13 10:44:12, anujsharma wrote: PTAL
6 years, 3 months ago (2014-09-13 10:44:26 UTC) #3
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-13 11:46:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573513002/1
6 years, 3 months ago (2014-09-13 11:47:38 UTC) #6
anujsharma
On 2014/09/13 11:46:12, Fady Samuel wrote: > lgtm Thanks fady for LGTM.
6 years, 3 months ago (2014-09-13 11:47:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 57b7925aef8aeaa1e1e8e17a6995cc83acf2955f
6 years, 3 months ago (2014-09-13 12:46:20 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 12:48:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb1951228bfc4c44e649f00d9a42c3d142a7227f
Cr-Commit-Position: refs/heads/master@{#294743}

Powered by Google App Engine
This is Rietveld 408576698