DevTools: Get rid of frontend_modules.json

Source/devtools/front_end/Runtime.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 199 matching lines @@
     var workerURL = window.URL.createObjectURL(blob);
     try {
         var worker = new Worker(workerURL);
         worker.postMessage(message);
         return worker;
     } finally {
         window.URL.revokeObjectURL(workerURL);
     }
 }
 
+Runtime._coreModules = ["common", "host", "sdk", "ui", "components", "workspace", "bindings", "screencast", "toolbox", "main"];

[pfeldman, 2014/09/19 11:35:35]

Lets feed them to runtime as we do with configuration.

[apavlov, 2014/09/19 13:09:40]

Done.

+
 Runtime.prototype = {
     /**
      * @param {!Array.<string>} configuration
      */
     registerModules: function(configuration)
     {
         for (var i = 0; i < configuration.length; ++i)
             this._registerModule(configuration[i]);
     },
 
     /**
      * @param {string} moduleName
      */
     _registerModule: function(moduleName)
     {
         if (!this._descriptorsMap[moduleName]) {
-            var content = loadResource(moduleName + "/module.json");
+            var content;
+            // FIXME: This is a temp workaround to avoid core module loading attempts in the release mode.
+            // It should be removed when the new application loader is implemented.
+            if (Runtime._coreModules.indexOf(moduleName) === -1)
+                content = loadResource(moduleName + "/module.json");
+            else
+                content = "{}";
+
             if (!content)
                 throw new Error("Module is not defined: " + moduleName + " " + new Error().stack);
+
             var module = /** @type {!Runtime.ModuleDescriptor} */ (self.eval("(" + content + ")"));
             module["name"] = moduleName;
             this._descriptorsMap[moduleName] = module;
         }
         var module = new Runtime.Module(this, this._descriptorsMap[moduleName]);
         this._modules.push(module);
         this._modulesMap[moduleName] = module;
     },
 
     /**
@@ skipping 281 matching lines @@
             Error.stackTraceLimit = oldStackTraceLimit;
             return;
         }
 
         this._isLoading = true;
         var dependencies = this._descriptor.dependencies;
         for (var i = 0; dependencies && i < dependencies.length; ++i)
             this._manager.loadModule(dependencies[i]);
         if (this._descriptor.scripts) {
             if (Runtime.isReleaseMode()) {
-                loadScript(this._name + ".js");
+                // FIXME: This is a temp workaround to avoid core module loading attempts in the release mode.
+                // It should be removed when the new application loader is implemented.
+                if (Runtime._coreModules.indexOf(this._name) === -1)
+                    loadScript(this._name + ".js");
             } else {
                 var scripts = this._descriptor.scripts;
                 for (var i = 0; i < scripts.length; ++i)
                     loadScript(this._name + "/" + scripts[i]);
             }
         }
         this._isLoading = false;
         this._loaded = true;
     }
 }
@@ skipping 71 matching lines @@
             this._instance = new constructorFunction();
         }
         return this._instance;
     }
 }
 
 /**
  * @type {!Runtime}
  */
 var runtime;