Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: components/metrics/metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service_client.h
diff --git a/components/metrics/metrics_service_client.h b/components/metrics/metrics_service_client.h
index 465cb01fe67dc80c757c9e702c2ade196131303a..98b41ce4b96d2754e94fba5cf9d0534e42a88128 100644
--- a/components/metrics/metrics_service_client.h
+++ b/components/metrics/metrics_service_client.h
@@ -30,6 +30,11 @@ class MetricsServiceClient {
// Whether there's an "off the record" (aka "Incognito") session active.
virtual bool IsOffTheRecordSessionActive() = 0;
+ // Returns the product value to use in uploaded reports, which will be used to
+ // set the ChromeUserMetricsExtension.product field. See comments on that
+ // field on why it's an int32 rather than an enum.
+ virtual int32 GetProduct() = 0;
Ilya Sherman 2014/09/25 18:29:55 According to basictypes.h, we should use int32_t i
Alexei Svitkine (slow) 2014/09/26 16:51:09 Done.
+
// Returns the current application locale (e.g. "en-US").
virtual std::string GetApplicationLocale() = 0;

Powered by Google App Engine
This is Rietveld 408576698