chromecast/metrics/cast_metrics_service_client.cc - Issue 573403002: Change UMA proto product field to be an int32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/metrics/cast_metrics_service_client.cc

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/metrics/cast_metrics_service_client.cc

diff --git a/chromecast/metrics/cast_metrics_service_client.cc b/chromecast/metrics/cast_metrics_service_client.cc

index 637cd400b864e484b3300b51d33eb69ce8076ce2..158fe5a15fe3af2424049f9b14a0d1cf2d7fb021 100644

--- a/chromecast/metrics/cast_metrics_service_client.cc

+++ b/chromecast/metrics/cast_metrics_service_client.cc

@@ -54,6 +54,11 @@ bool CastMetricsServiceClient::IsOffTheRecordSessionActive() {

return false;

}

+int32 CastMetricsServiceClient::GetProduct() {

+ // Chromecast currently uses the same product identifier as Chrome.

+ return metrics::ChromeUserMetricsExtension::CHROME;

std::string CastMetricsServiceClient::GetApplicationLocale() {

return base::i18n::GetConfiguredLocale();

}