Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: components/metrics/test_metrics_service_client.cc

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and add a couple of tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/test_metrics_service_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/test_metrics_service_client.cc
diff --git a/components/metrics/test_metrics_service_client.cc b/components/metrics/test_metrics_service_client.cc
index e5e97780ec0fad9d4688c0198397ff70908363b1..c60db0b151bbc75be86c5564e0ed68453454e9bb 100644
--- a/components/metrics/test_metrics_service_client.cc
+++ b/components/metrics/test_metrics_service_client.cc
@@ -6,6 +6,7 @@
#include "base/callback.h"
#include "components/metrics/metrics_log_uploader.h"
+#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
namespace metrics {
@@ -13,7 +14,8 @@ namespace metrics {
const char TestMetricsServiceClient::kBrandForTesting[] = "brand_for_testing";
TestMetricsServiceClient::TestMetricsServiceClient()
- : version_string_("5.0.322.0-64-devel") {
+ : version_string_("5.0.322.0-64-devel"),
+ product_(ChromeUserMetricsExtension::CHROME) {
}
TestMetricsServiceClient::~TestMetricsServiceClient() {
@@ -28,6 +30,10 @@ bool TestMetricsServiceClient::IsOffTheRecordSessionActive() {
return false;
}
+int32_t TestMetricsServiceClient::GetProduct() {
+ return product_;
+}
+
std::string TestMetricsServiceClient::GetApplicationLocale() {
return "en-US";
}
« no previous file with comments | « components/metrics/test_metrics_service_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698