Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: components/metrics/metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and add a couple of tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service_client.h
diff --git a/components/metrics/metrics_service_client.h b/components/metrics/metrics_service_client.h
index 465cb01fe67dc80c757c9e702c2ade196131303a..4289bae899395eb823b2856d983912ed7f6d6357 100644
--- a/components/metrics/metrics_service_client.h
+++ b/components/metrics/metrics_service_client.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_METRICS_METRICS_SERVICE_CLIENT_H_
#define COMPONENTS_METRICS_METRICS_SERVICE_CLIENT_H_
+#include <stdint.h>
#include <string>
#include "base/basictypes.h"
@@ -30,6 +31,11 @@ class MetricsServiceClient {
// Whether there's an "off the record" (aka "Incognito") session active.
virtual bool IsOffTheRecordSessionActive() = 0;
+ // Returns the product value to use in uploaded reports, which will be used to
+ // set the ChromeUserMetricsExtension.product field. See comments on that
+ // field on why it's an int32 rather than an enum.
+ virtual int32_t GetProduct() = 0;
+
// Returns the current application locale (e.g. "en-US").
virtual std::string GetApplicationLocale() = 0;
« no previous file with comments | « components/metrics/metrics_log_unittest.cc ('k') | components/metrics/proto/chrome_user_metrics_extension.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698