chromecast/metrics/cast_metrics_service_client.h - Issue 573403002: Change UMA proto product field to be an int32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/metrics/cast_metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and add a couple of tests. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/metrics/cast_metrics_service_client.h

diff --git a/chromecast/metrics/cast_metrics_service_client.h b/chromecast/metrics/cast_metrics_service_client.h

index fc55aea882f03cba3720336ed98c47b9737dc7c6..defb58842cf05eaf23cdaf4a41819ee1922f7fc0 100644

--- a/chromecast/metrics/cast_metrics_service_client.h

+++ b/chromecast/metrics/cast_metrics_service_client.h

@@ -42,6 +42,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

// metrics::MetricsServiceClient implementation:

virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE;

virtual bool IsOffTheRecordSessionActive() OVERRIDE;

+ virtual int32_t GetProduct() OVERRIDE;

virtual std::string GetApplicationLocale() OVERRIDE;

virtual bool GetBrand(std::string* brand_code) OVERRIDE;

virtual ::metrics::SystemProfileProto::Channel GetChannel() OVERRIDE;