Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57333002: ChromeOS: Accept NULL SystemBus in MediaTransferProtocolManager. (Closed)

Created:
7 years, 1 month ago by pneubeck (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang, satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

ChromeOS: Accept NULL SystemBus in MediaTransferProtocolManager. DBusThreadManager's GetSystemBus returns NULL if Chrome built for ChromeOS runs on Linux or in tests. BUG=275286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233056

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Check GetBus() in destructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -83 lines) Patch
M device/media_transfer_protocol/media_transfer_protocol_daemon_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc View 2 chunks +2 lines, -65 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 1 2 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pneubeck (no reviews)
7 years, 1 month ago (2013-11-03 20:19:10 UTC) #1
satorux1
please also get this reviewed by thesgig@ https://codereview.chromium.org/57333002/diff/70001/device/media_transfer_protocol/media_transfer_protocol_manager.cc File device/media_transfer_protocol/media_transfer_protocol_manager.cc (right): https://codereview.chromium.org/57333002/diff/70001/device/media_transfer_protocol/media_transfer_protocol_manager.cc#newcode70 device/media_transfer_protocol/media_transfer_protocol_manager.cc:70: GetBus()->UnlistenForServiceOwnerChange(mtpd::kMtpdServiceName, check ...
7 years, 1 month ago (2013-11-05 03:41:18 UTC) #2
Lei Zhang
Satorux's comment is my only concern as well.
7 years, 1 month ago (2013-11-05 05:44:29 UTC) #3
satorux1
LGTM if the comment in ~MediaTransferProtocolManagerImpl is addressed.
7 years, 1 month ago (2013-11-05 07:18:51 UTC) #4
pneubeck (no reviews)
https://codereview.chromium.org/57333002/diff/70001/device/media_transfer_protocol/media_transfer_protocol_manager.cc File device/media_transfer_protocol/media_transfer_protocol_manager.cc (right): https://codereview.chromium.org/57333002/diff/70001/device/media_transfer_protocol/media_transfer_protocol_manager.cc#newcode70 device/media_transfer_protocol/media_transfer_protocol_manager.cc:70: GetBus()->UnlistenForServiceOwnerChange(mtpd::kMtpdServiceName, On 2013/11/05 03:41:18, satorux1 wrote: > check GetBus() ...
7 years, 1 month ago (2013-11-05 09:54:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/57333002/140001
7 years, 1 month ago (2013-11-05 09:55:52 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 10:09:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/57333002/140001
7 years, 1 month ago (2013-11-05 10:18:04 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219563
7 years, 1 month ago (2013-11-05 14:17:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/57333002/140001
7 years, 1 month ago (2013-11-05 16:52:25 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 19:38:14 UTC) #11
Message was sent while issue was closed. 
Change committed as 233056

Powered by Google App Engine
This is Rietveld 408576698