Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 573323002: Add SkMiniData. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, bungeman-skia, fmalita_google_do_not_use
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SkMiniData. This is a bit like a limited SkData, geared to store really tiny byte strings. This is not hooked up anywhere beyond the new unit test. I did experimentally plumb it into SkRecord for drawPosTextH: just over 40% of drawPosTextH calls in our repo can fit into ShortData. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6a5c7085bcebe263ac43486f1825407580662924

Patch Set 1 #

Patch Set 2 : endian #

Patch Set 3 : narrowing #

Patch Set 4 : MSVC doesn't like uint8_t data[0]. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M gyp/core.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkMiniData.h View 1 chunk +24 lines, -0 lines 0 comments Download
A src/core/SkMiniData.cpp View 1 2 3 1 chunk +80 lines, -0 lines 0 comments Download
A tests/MiniDataTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573323002/40001
6 years, 3 months ago (2014-09-17 17:56:59 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-17 17:57:00 UTC) #3
mtklein
6 years, 3 months ago (2014-09-17 18:00:53 UTC) #5
reed1
lgtm
6 years, 3 months ago (2014-09-17 18:19:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573323002/60001
6 years, 3 months ago (2014-09-17 18:35:39 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 19:22:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 6a5c7085bcebe263ac43486f1825407580662924

Powered by Google App Engine
This is Rietveld 408576698