Chromium Code Reviews
Help | Chromium Project | Sign in
(371)

Issue 5733004: Attempt to fix compare performance regression.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Vitaly Repeshko
Modified:
3 years, 4 months ago
Reviewers:
fschneider
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Attempt to fix compare performance regression.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Lint Patch
M src/ia32/ic-ia32.cc View 1 chunk +12 lines, -1 line 0 comments 0 errors Download
M src/ic.h View 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M src/ic.cc View 1 chunk +7 lines, -4 lines 1 comment ? errors Download
Trybot results: Sign in to try more bots
Commit:

Issue must be closed to Revert

Messages

Total messages: 2
Vitaly Repeshko
3 years, 4 months ago #1
fschneider
3 years, 4 months ago #2
LGTM!

http://codereview.chromium.org/5733004/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/5733004/diff/1/src/ic.cc#newcode2142
src/ic.cc:2142: x->IsNumber() && y->IsNumber()) return HEAP_NUMBERS;
Would the condition 
(state == UNINITIALIZED || state == SMIS) &&
x->IsNumber() &&
y->IsNumber())

be sufficient here? So that we always go from SMI to HEAP_NUMBER before going to
GENERIC.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6