Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 573293005: syncxhr doesn't deadlock layout test (Closed)

Created:
6 years, 3 months ago by michaeln
Modified:
6 years, 2 months ago
CC:
blink-reviews, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Layout test to ensure we bypass ServiceWorkers for synchronous resource loads to avoid deadlocks when the worker and page are running in the same process. [1] https://codereview.chromium.org/553333005/ [2] this cl BUG=413103 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182888

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock.data View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock-iframe.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/sync-xhr-doesnt-deadlock.html View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
michaeln
ptal, i can't land this until the other change is in
6 years, 3 months ago (2014-09-17 23:09:54 UTC) #2
horo
lgtm with nits. https://codereview.chromium.org/573293005/diff/1/LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock-iframe.html File LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock-iframe.html (right): https://codereview.chromium.org/573293005/diff/1/LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock-iframe.html#newcode5 LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock-iframe.html:5: var url = 'sync-xhr-doesnt-deadlock.data?bustcache=' + Date.now(); ...
6 years, 3 months ago (2014-09-18 01:04:29 UTC) #3
michaeln
On 2014/09/18 01:04:29, horo wrote: > lgtm with nits. > > https://codereview.chromium.org/573293005/diff/1/LayoutTests/http/tests/serviceworker/resources/sync-xhr-doesnt-deadlock-iframe.html > File > ...
6 years, 2 months ago (2014-09-30 00:42:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573293005/40001
6 years, 2 months ago (2014-09-30 05:42:16 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 06:46:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 182888

Powered by Google App Engine
This is Rietveld 408576698