Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 573253002: mojo: Add async waiter for python bindings (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add async waiter for python bindings BUG=415486 R=sdefresne@chromium.org,cmasone@chromium.org Committed: https://crrev.com/992eab604392410cf364186724380fb7cd235568 Cr-Commit-Position: refs/heads/master@{#295480}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Follow review #

Patch Set 3 : Fix compilation due to pre-processor variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -13 lines) Patch
M mojo/public/python/mojo/c_environment.pxd View 1 3 chunks +21 lines, -3 lines 0 comments Download
M mojo/public/python/mojo/system.pyx View 2 chunks +14 lines, -0 lines 0 comments Download
M mojo/public/python/src/python_system_helper.h View 1 2 1 chunk +31 lines, -3 lines 0 comments Download
M mojo/public/python/src/python_system_helper.cc View 1 5 chunks +99 lines, -7 lines 0 comments Download
A mojo/python/tests/async_wait_unittest.py View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
qsr
6 years, 3 months ago (2014-09-17 15:36:01 UTC) #1
sdefresne
https://codereview.chromium.org/573253002/diff/1/mojo/public/python/src/python_system_helper.cc File mojo/public/python/src/python_system_helper.cc (right): https://codereview.chromium.org/573253002/diff/1/mojo/public/python/src/python_system_helper.cc#newcode98 mojo/public/python/src/python_system_helper.cc:98: internal::SharedPtr<mojo::Callback<void(MojoResult)> > self = Why don't you DCHECK that ...
6 years, 3 months ago (2014-09-18 08:37:01 UTC) #2
qsr
https://codereview.chromium.org/573253002/diff/1/mojo/public/python/src/python_system_helper.cc File mojo/public/python/src/python_system_helper.cc (right): https://codereview.chromium.org/573253002/diff/1/mojo/public/python/src/python_system_helper.cc#newcode98 mojo/public/python/src/python_system_helper.cc:98: internal::SharedPtr<mojo::Callback<void(MojoResult)> > self = On 2014/09/18 08:37:01, sdefresne wrote: ...
6 years, 3 months ago (2014-09-18 08:56:11 UTC) #3
sdefresne
lgtm
6 years, 3 months ago (2014-09-18 09:14:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573253002/20001
6 years, 3 months ago (2014-09-18 12:22:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/245)
6 years, 3 months ago (2014-09-18 12:32:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573253002/20001
6 years, 3 months ago (2014-09-18 14:09:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/16767)
6 years, 3 months ago (2014-09-18 14:20:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573253002/40001
6 years, 3 months ago (2014-09-18 15:23:36 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 490a0d19f8fa851d2828b1c0f6276f76f9b1c8e6
6 years, 3 months ago (2014-09-18 16:24:01 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 16:24:42 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/992eab604392410cf364186724380fb7cd235568
Cr-Commit-Position: refs/heads/master@{#295480}

Powered by Google App Engine
This is Rietveld 408576698