Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 573233002: Video Player: Prevent showing the status icon on unnecessary timing (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Prevent showing the status icon on unnecessary timing Sometimes, the status icon was shown in unexpected timing. This might be because the animation is re-fired when the dom is restyled. This patch fixes it. BUG=none TEST=Open window->play video->pause->close window. Repeat it 20 times and observe no issue. Committed: https://crrev.com/41d134f66c8b63bc4be8ecfbad4aa054a5c6cbf5 Cr-Commit-Position: refs/heads/master@{#295895}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : improve reliability of short-interval clicks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M ui/file_manager/video_player/css/media_controls.css View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 2 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-18 04:27:11 UTC) #2
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-18 11:35:06 UTC) #3
fukino
On 2014/09/18 11:35:06, yoshiki wrote: > @fukino-san, PTAL. Thanks. Sorry for being late. lgtm. Thanks!
6 years, 3 months ago (2014-09-19 07:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573233002/40001
6 years, 3 months ago (2014-09-20 17:10:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 6b7ccba6b301dea05f162c6231502110f824c391
6 years, 3 months ago (2014-09-20 22:31:14 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 22:31:51 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/41d134f66c8b63bc4be8ecfbad4aa054a5c6cbf5
Cr-Commit-Position: refs/heads/master@{#295895}

Powered by Google App Engine
This is Rietveld 408576698