Add WebView browser test for MediaStreamTrack.getSources and CheckMediaAccessPermisson.

Add WebView browser test for MediaStreamTrack.getSources and CheckMediaAccessPermisson.

Follow up to https://codereview.chromium.org/562263002/

BUG=406094
Committed: https://crrev.com/ae12db637f75fa98cfd65b833a3a9addfcfe4278
Cr-Commit-Position: refs/heads/master@{#297519}

[Henrik Grunell, 2014-09-17 09:44:31]

grunell@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Henrik Grunell, 2014-09-17 09:47:27]

First super-hacky attempt to write a test. It times out. I wonder where
embedderWindowChannel.postMessage('got-sources', '*');
ends up? Somewhere I need to post to the test that it passed. 

In the allow/deny tests that's done already in the permission request event, but
I don't have that here.

[Fady Samuel, 2014-09-18 18:33:22]

fsamuel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Fady Samuel, 2014-09-18 18:33:23]

+lazyboy@, passing this along to Istiaque who wrote the original media access
<webview> test.

[lazyboy, 2014-09-18 18:59:56]

Sending some comments to help you proceed with the test. HTH.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js
(right):

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:41:
// Send post message to <webview> when it's ready to receive them.
Log here to be sure this is getting called, see comment below.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:85:
embedder.setUpLoadStop_(webview);
By the time we reach here, we might already have missed loadstop, do you think
you're hitting this case?
Setting .src to <webview> starts navigating it right away.
The correct order to do it would be
create <webview> element but don't set .src attribute.
then add event handler for loadstop.
then set the .src attribute.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:86:

Also add a consolemessage event to webview to see logs from the guest/webview.
<webview>.addEventListener('consolemessage', function(e) {
window.console.log(e.message); });

[Henrik Grunell, 2014-09-19 07:23:27]

I won't continue with the test today, but I have answered some comments.

I still don't understand how the embedder is notified by webview when we've got
the sources.

What does
embedderWindowChannel.postMessage('got-sources', '*');
in media_check_guest.html do?

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js
(right):

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:21:
chrome.test.sendMessage('TEST_PASSED');
Note: this will never happen - maybePassTest is not called from anywhere. When
should this be called?

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:85:
embedder.setUpLoadStop_(webview);
On 2014/09/18 18:59:56, lazyboy wrote:
> By the time we reach here, we might already have missed loadstop, do you think
> you're hitting this case?

No idea. The code is copied from the allow and deny test cases. (E.g.
.../web_view/media_access/allow/) I hope it works here if it does in those.

> Setting .src to <webview> starts navigating it right away.
> The correct order to do it would be
> create <webview> element but don't set .src attribute.
> then add event handler for loadstop.
> then set the .src attribute.

I'll change that.

[lazyboy, 2014-09-19 16:34:35]

What does
embedderWindowChannel.postMessage('got-sources', '*');
in media_check_guest.html do?

It sends post message back to the embedder, now I see you don't have a message
handler in the embedder to receive the message, see the code below to see how
that can be done:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...

[Henrik Grunell, 2014-09-30 12:25:05]

Code review. Some fixes, cleaning, etc. Test now works and passes.

Ptal.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js
(right):

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:41:
// Send post message to <webview> when it's ready to receive them.
On 2014/09/18 18:59:56, lazyboy wrote:
> Log here to be sure this is getting called, see comment below.

I assume you mean it has to post a message? Done. (I have no idea about the
style, practicing best effort.)

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:85:
embedder.setUpLoadStop_(webview);
On 2014/09/19 07:23:27, Henrik Grunell wrote:
> On 2014/09/18 18:59:56, lazyboy wrote:
> > By the time we reach here, we might already have missed loadstop, do you
think
> > you're hitting this case?
> 
> No idea. The code is copied from the allow and deny test cases. (E.g.
> .../web_view/media_access/allow/) I hope it works here if it does in those.
> 
> > Setting .src to <webview> starts navigating it right away.
> > The correct order to do it would be
> > create <webview> element but don't set .src attribute.
> > then add event handler for loadstop.
> > then set the .src attribute.
> 
> I'll change that.

Done, hope I got it right.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:86:

On 2014/09/18 18:59:56, lazyboy wrote:
> Also add a consolemessage event to webview to see logs from the guest/webview.
> <webview>.addEventListener('consolemessage', function(e) {
> window.console.log(e.message); });

Done.

[Henrik Grunell, 2014-09-30 12:27:20]

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js
(right):

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:21:
chrome.test.sendMessage('TEST_PASSED');
On 2014/09/19 07:23:27, Henrik Grunell wrote:
> Note: this will never happen - maybePassTest is not called from anywhere. When
> should this be called?

This comment is obsolete.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:41:
// Send post message to <webview> when it's ready to receive them.
On 2014/09/30 12:25:04, Henrik Grunell wrote:
> On 2014/09/18 18:59:56, lazyboy wrote:
> > Log here to be sure this is getting called, see comment below.
> 
> I assume you mean it has to post a message? Done. (I have no idea about the
> style, practicing best effort.)

Forget this; figured it out later.

https://codereview.chromium.org/573183002/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:85:
embedder.setUpLoadStop_(webview);
On 2014/09/30 12:25:04, Henrik Grunell wrote:
> On 2014/09/19 07:23:27, Henrik Grunell wrote:
> > On 2014/09/18 18:59:56, lazyboy wrote:
> > > By the time we reach here, we might already have missed loadstop, do you
> think
> > > you're hitting this case?
> > 
> > No idea. The code is copied from the allow and deny test cases. (E.g.
> > .../web_view/media_access/allow/) I hope it works here if it does in those.
> > 
> > > Setting .src to <webview> starts navigating it right away.
> > > The correct order to do it would be
> > > create <webview> element but don't set .src attribute.
> > > then add event handler for loadstop.
> > > then set the .src attribute.
> > 
> > I'll change that.
> 
> Done, hope I got it right.

I actually didn't get it right, so I reverted the change. Test passes now
however.

[lazyboy, 2014-09-30 16:29:29]

LGTM with one nit.

https://codereview.chromium.org/573183002/diff/60001/chrome/test/data/extensi...
File
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js
(right):

https://codereview.chromium.org/573183002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:82:
if (data[0] == 'got-sources')
nit: Use curly braces (JS).

[Henrik Grunell, 2014-09-30 16:42:58]

https://codereview.chromium.org/573183002/diff/60001/chrome/test/data/extensi...
File
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js
(right):

https://codereview.chromium.org/573183002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/web_view/media_access/check/embedder.js:82:
if (data[0] == 'got-sources')
On 2014/09/30 16:29:29, lazyboy wrote:
> nit: Use curly braces (JS).

Done.

[Henrik Grunell, 2014-09-30 16:43:08]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2014-09-30 16:44:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/573183002/80001

[commit-bot: I haz the power, 2014-09-30 22:11:16]

Committed patchset #5 (id:80001) as 6bff28a28024e48206b92bd52c01f27f64e0b89a

[commit-bot: I haz the power, 2014-09-30 22:12:24]

Patchset 5 (id:??) landed as
https://crrev.com/ae12db637f75fa98cfd65b833a3a9addfcfe4278
Cr-Commit-Position: refs/heads/master@{#297519}