chrome/browser/ui/cocoa/base_bubble_controller.mm - Issue 573143002: Mac: Give bubble windows an initial position before showing them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 573143002: Mac: Give bubble windows an initial position before showing them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: setAnchorPoint Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/base_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm

index 2cc0a965300b87f4e6e9802316e20385f86f6293..00ca58fca0b8d736b7f20925b1859ce79d009869 100644

--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm

@@ -72,7 +72,6 @@

DCHECK(theWindow);

if ((self = [super initWithWindow:theWindow])) {

parentWindow_ = parentWindow;

- anchor_ = anchoredAt;

shouldOpenAsKeyWindow_ = YES;

shouldCloseOnResignKey_ = YES;

@@ -86,6 +85,7 @@

[self registerForNotifications];

[self awakeFromNib];

+ [self setAnchorPoint:anchoredAt];

}

return self;

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm » ('j') | no next file with comments »