Mac: Give bubble windows an initial position before showing them.

chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 
 #include <algorithm>
 
 #include "base/callback.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 156 matching lines @@
   if ((self = [super initWithWindow:window
                        parentWindow:parentWindow
                          anchoredAt:anchoredAt])) {
     host_.reset(host);
     beingInspected_ = devMode;
     ignoreWindowDidResignKey_ = NO;
 
     InfoBubbleView* view = self.bubble;
     [view setArrowLocation:arrowLocation];
 
+    // alternative1: call [view setAnchorPoint:anchoredAt] here, drop the
+    // onWindowChanged diff chunk. (or some kind of positionWindow call).
+
+    // alternative2: hook into that setArrowLocation above in the bubble
+    // controller (also: alignment), and keep the window position consistent.
+
     extensionView_ = host->view()->GetNativeView();
     container_.reset(new ExtensionPopupContainer(self));
     static_cast<ExtensionViewMac*>(host->view())
         ->set_container(container_.get());
 
     NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
     [center addObserver:self
                selector:@selector(extensionViewFrameChanged)
                    name:NSViewFrameDidChangeNotification
                  object:extensionView_];
@@ skipping 209 matching lines @@
 
   [extensionView_ setFrame:frame];
   [extensionView_ setNeedsDisplay:YES];
 }
 
 - (void)onViewDidShow {
   [self onSizeChanged:pendingSize_];
 }
 
 - (void)onWindowChanged {
+  // The window is positioned before creating the host, to ensure the host is
+  // created with the correct screen information.
+  if (!host_)
+    return;
+
   ExtensionViewMac* extensionView =
       static_cast<ExtensionViewMac*>(host_->view());
   // Let the extension view know, so that it can tell plugins.
   if (extensionView)
     extensionView->WindowFrameChanged();
 }
 
 - (void)windowDidResize:(NSNotification*)notification {
   [self onWindowChanged];
 }
@@ skipping 13 matching lines @@
   return minSize;
 }
 
 // Private (TestingAPI)
 + (NSSize)maxPopupSize {
   NSSize maxSize = {ExtensionViewMac::kMaxWidth, ExtensionViewMac::kMaxHeight};
   return maxSize;
 }
 
 @end