Mac: Give bubble windows an initial position before showing them.

chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
@@ skipping 179 matching lines @@
 
   NSRect frame = [[controller_ window] frame];
   // Make sure the bubble size hasn't changed.
   EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble arrow points to the anchor.
   EXPECT_EQ(NSMidX(frame), kAnchorPointX);
   EXPECT_GE(NSMaxY(frame), kAnchorPointY);
 }
 
+// Test that the window is given an initial position before being shown. This
+// ensures offscreen initialization is done using correct screen metrics.
+TEST_F(BaseBubbleControllerTest, PositionedBeforeShow) {
+  // Verify default alignment settings, used when initialized in SetUp().
+  EXPECT_EQ(info_bubble::kTopRight, [[controller_ bubble] arrowLocation]);
+  EXPECT_EQ(info_bubble::kAlignArrowToAnchor, [[controller_ bubble] alignment]);
+
+  // Verify the default frame (positioned relative to the test_window() origin).
+  NSRect frame = [[controller_ window] frame];
+  EXPECT_EQ(NSMaxX(frame) - info_bubble::kBubbleArrowXOffset -
+      floorf(info_bubble::kBubbleArrowWidth / 2.0), kAnchorPointX);
+  EXPECT_EQ(NSMaxY(frame), kAnchorPointY);
+}
+
 // Tests that when a new window gets key state (and the bubble resigns) that
 // the key window changes.
 TEST_F(BaseBubbleControllerTest, ResignKeyCloses) {
   // Closing the bubble will autorelease the controller.
   base::scoped_nsobject<BaseBubbleController> keep_alive([controller_ retain]);
 
   NSWindow* bubble_window = [controller_ window];
   EXPECT_FALSE([bubble_window isVisible]);
 
   base::scoped_nsobject<NSWindow> other_window(
@@ skipping 124 matching lines @@
   [NSApp sendEvent:event];
 
   // When we got here, menu has already run its RunLoop.
   // See -[ContextualMenuController menuWillOpen:].
   EXPECT_FALSE([window isVisible]);
 
   EXPECT_FALSE([menu_controller isMenuOpen]);
   EXPECT_TRUE([menu_controller didOpen]);
 }