Mac: Give bubble windows an initial position before showing them.

chrome/browser/ui/cocoa/base_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
@@ skipping 68 matching lines @@
     DCHECK(![[self window] delegate]);
     [theWindow setDelegate:self];
 
     base::scoped_nsobject<InfoBubbleView> contentView(
         [[InfoBubbleView alloc] initWithFrame:NSZeroRect]);
     [theWindow setContentView:contentView.get()];
     bubble_ = contentView.get();
 
     [self registerForNotifications];
     [self awakeFromNib];
+    [self updateOriginFromAnchor];

[Robert Sesek, 2014/09/17 16:52:48]

Why not do [self setAnchorPoint:] instead?

[tapted, 2014/09/18 02:58:22]

Done.

The nib codepaths complicate things a bit -- updateOriginFromAnchor needs to
happen after awakeFromNib (it sets the arrow location on InfoBubbleView which is
an IBOutlet), which is why they're ordered like this in showWindow as well (and
why we can't just move that setArrowLocation to the initializers)

But nothing leading up to the end of awakeFromNib relies on the anchor_, so
setAnchorPoint here works too.

   }
   return self;
 }
 
 - (void)awakeFromNib {
   // Check all connections have been made in Interface Builder.
   DCHECK([self window]);
   DCHECK(bubble_);
   DCHECK_EQ(self, [[self window] delegate]);
 
@@ skipping 269 matching lines @@
 
 - (void)activateTabWithContents:(content::WebContents*)newContents
                previousContents:(content::WebContents*)oldContents
                         atIndex:(NSInteger)index
                          reason:(int)reason {
   // The user switched tabs; close.
   [self close];
 }
 
 @end  // BaseBubbleController