Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 573133003: Code re-factor related to WeakPtrFactory in src/component module (Closed)

Created:
6 years, 3 months ago by ARUNKK
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, dconnelly
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Code re-factor related to WeakPtrFactory in src/component module Changing in the initialization order of WeakPtrFactory in src/gin module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructor are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/1293c75eefdc19ac66a3505d09d6f49aea508373 Cr-Commit-Position: refs/heads/master@{#295439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M components/policy/core/browser/url_blacklist_manager.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/policy/core/browser/url_blacklist_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/policy/core/common/async_policy_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
ARUNKK
PTAL
6 years, 3 months ago (2014-09-17 06:32:09 UTC) #2
Lei Zhang
storage monitor lgtm, but I'm not a policy OWNER
6 years, 3 months ago (2014-09-17 18:37:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573133003/1
6 years, 3 months ago (2014-09-18 01:19:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11740)
6 years, 3 months ago (2014-09-18 01:29:54 UTC) #7
ARUNKK
dconnelly@chromium.org: Please review changes in PTAL.
6 years, 3 months ago (2014-09-18 03:00:35 UTC) #9
dconnelly
components/policy lgtm
6 years, 3 months ago (2014-09-18 08:36:53 UTC) #10
ARUNKK
On 2014/09/18 08:36:53, dconnelly wrote: > components/policy lgtm Thanks for lgtm.
6 years, 3 months ago (2014-09-18 08:38:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573133003/1
6 years, 3 months ago (2014-09-18 08:38:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 95e84c96e1f7acbf3f16beb91dce54459e7c2742
6 years, 3 months ago (2014-09-18 09:06:29 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 09:07:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1293c75eefdc19ac66a3505d09d6f49aea508373
Cr-Commit-Position: refs/heads/master@{#295439}

Powered by Google App Engine
This is Rietveld 408576698