Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 573123003: X87: Removing ic.h from code-stubs.h (Closed)

Created:
6 years, 3 months ago by Jing
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Removing ic.h from code-stubs.h port r23977. original commit message: Removing ic.h from code-stubs.h CodeStubs use state types defined in ic.h, but this has the unfortunate effect of spreading ic.h all over the place. Instead, define these shared state types in ic-public.h and allow ic.h to concern itself with internal state change of the ICs. More work could/should be done here, but this is a first step. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 13 chunks +21 lines, -19 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jing
6 years, 3 months ago (2014-09-17 01:54:22 UTC) #2
Weiliang
lgtm
6 years, 3 months ago (2014-09-17 03:02:50 UTC) #3
Weiliang
6 years, 3 months ago (2014-09-17 05:22:30 UTC) #4
Committed as r23992

Powered by Google App Engine
This is Rietveld 408576698