Relax shared module whitelist restriction

chrome/common/pepper_permission_util_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pepper_permission_util.h"
 
 #include <set>
 #include <string>
 
 #include "chrome/common/extensions/features/feature_channel.h"
@@ skipping 97 matching lines @@
   // Important: whitelist *only* the shared module.
   whitelist.insert(shared_module->id());
 
   extensions.Insert(ext);
   // This should fail because shared_module is not in the set of extensions.
   EXPECT_FALSE(IsExtensionOrSharedModuleWhitelisted(
       GURL(extension_url), &extensions, whitelist));
   extensions.Insert(shared_module);
   EXPECT_TRUE(IsExtensionOrSharedModuleWhitelisted(
       GURL(extension_url), &extensions, whitelist));
-  scoped_refptr<Extension> bad_ext =
+  scoped_refptr<Extension> not_in_sm_whitelist =
       CreateExtensionImportingModule(shared_module->id(), bad_id);
-  std::string bad_extension_url = std::string("chrome-extension://") +
-                                  bad_ext->id() + std::string("/foo.html");
+  std::string not_in_sm_whitelist_url = std::string("chrome-extension://") +
+                                        not_in_sm_whitelist->id() +
+                                        std::string("/foo.html");
 
-  extensions.Insert(bad_ext);
-  // This should fail because bad_ext is not whitelisted to use shared_module.
-  EXPECT_FALSE(IsExtensionOrSharedModuleWhitelisted(
-      GURL(bad_extension_url), &extensions, whitelist));
+  extensions.Insert(not_in_sm_whitelist);
+  // This should succeed, even though |not_in_sm_whitelist| is not whitelisted
+  // to use shared_module, because the pepper permission utilitiy does not care

[Ken Rockot(use gerrit already), 2014/09/17 17:32:54]

nit: "utility"

[elijahtaylor1, 2014/09/17 17:41:03]

Done.

+  // about that whitelist.  It is possible to install against the whitelist as
+  // an unpacked extension.
+  EXPECT_TRUE(IsExtensionOrSharedModuleWhitelisted(
+      GURL(not_in_sm_whitelist_url), &extensions, whitelist));
 
   // Note that the whitelist should be empty after this call, so tests checking
   // for failure to import will fail because of this.
   whitelist.erase(shared_module->id());
   EXPECT_FALSE(IsExtensionOrSharedModuleWhitelisted(
       GURL(extension_url), &extensions, whitelist));
 }
 
 }  // namespace extensions