Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 573073003: Move content_gl_tests.isolate to content. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org, Ian Vollick, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move content_gl_tests.isolate to content. I noticed this while looking through isolate files. Since the test target is in content, the isolate file should be alongside. Committed: https://crrev.com/1351139b75882cf05417aa615df21d641870be3c Cr-Commit-Position: refs/heads/master@{#295983}

Patch Set 1 : git cl try #

Patch Set 2 : g #

Patch Set 3 : #

Patch Set 4 : add osmesa dependency #

Patch Set 5 : add ffmpeg dependency #

Patch Set 6 : reupload after 295514 #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 4 5 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/content_gl_tests.isolate View 1 chunk +0 lines, -34 lines 0 comments Download
A + content/content_gl_tests.isolate View 1 2 3 4 5 6 2 chunks +28 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 28 (13 generated)
jam
6 years, 3 months ago (2014-09-17 00:27:08 UTC) #3
Ken Russell (switch to Gerrit)
LGTM once this passes the bots. Maybe needs to include angle.isolate on Windows? The Mac ...
6 years, 3 months ago (2014-09-18 18:05:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573073003/140001
6 years, 3 months ago (2014-09-18 21:00:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5513)
6 years, 3 months ago (2014-09-18 21:38:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573073003/140001
6 years, 3 months ago (2014-09-19 00:18:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5580)
6 years, 3 months ago (2014-09-19 00:57:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573073003/160001
6 years, 3 months ago (2014-09-19 21:05:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573073003/160001
6 years, 3 months ago (2014-09-19 21:05:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5783) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/10728) ios_dbg_simulator ...
6 years, 3 months ago (2014-09-19 21:21:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573073003/240001
6 years, 3 months ago (2014-09-22 14:54:38 UTC) #23
commit-bot: I haz the power
Committed patchset #8 (id:240001) as a187432b715e1d5d070609f7be380fc5b2b2c3d2
6 years, 3 months ago (2014-09-22 16:29:12 UTC) #24
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/1351139b75882cf05417aa615df21d641870be3c Cr-Commit-Position: refs/heads/master@{#295983}
6 years, 3 months ago (2014-09-22 16:30:17 UTC) #25
Jamie Madill
On 2014/09/22 16:30:17, I haz the power (commit-bot) wrote: > Patchset 8 (id:??) landed as ...
6 years, 3 months ago (2014-09-22 18:54:03 UTC) #26
Jamie Madill
A revert of this CL (patchset #8 id:240001) has been created in https://codereview.chromium.org/590243002/ by jmadill@chromium.org. ...
6 years, 3 months ago (2014-09-22 18:54:35 UTC) #27
Ken Russell (switch to Gerrit)
6 years, 3 months ago (2014-09-22 19:18:55 UTC) #28
Message was sent while issue was closed.
Per discussion on https://codereview.chromium.org/590243002/ , since this CL
passed the commit queue we are going to directly debug what's failing on the
Win7 debug bots. It's probably something related to component=shared_library and
a missing DLL.

Powered by Google App Engine
This is Rietveld 408576698