Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5710)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 573073002: Use Web Manifest when creating a shortcut on Chrome Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: weakptr Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 04ef1bad004e0b3d030e89c002be712968d6205a..3a4fb6bf397fb23501f8946b3de8616d6b1a167c 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -16,6 +16,7 @@
namespace content {
class WebContents;
+struct Manifest;
} // namespace content
namespace IPC {
@@ -47,6 +48,9 @@ class ShortcutHelper : public content::WebContentsObserver {
// IPC message received when the initialization is finished.
void OnDidGetWebApplicationInfo(const WebApplicationInfo& web_app_info);
+ // Callback run when the Manifest is ready to be used.
+ void OnDidGetManifest(const content::Manifest& manifest);
+
// Adds a shortcut to the current URL to the Android home screen.
void AddShortcut(JNIEnv* env,
jobject obj,
@@ -84,6 +88,8 @@ class ShortcutHelper : public content::WebContentsObserver {
favicon_base::FaviconRawBitmapResult icon_;
base::CancelableTaskTracker cancelable_task_tracker_;
+ base::WeakPtrFactory<ShortcutHelper> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ShortcutHelper);
};
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698