Use Web Manifest when creating a shortcut on Chrome Android.

chrome/browser/android/shortcut_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_helper.h"
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/location.h"
 #include "base/strings/string16.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "base/threading/worker_pool.h"
 #include "chrome/browser/android/tab_android.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/web_application_info.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/frame_navigate_params.h"
+#include "content/public/common/manifest.h"
 #include "jni/ShortcutHelper_jni.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/color_analysis.h"
 #include "ui/gfx/favicon_size.h"
 #include "url/gurl.h"
 
 jlong Initialize(JNIEnv* env, jobject obj, jlong tab_android_ptr) {
   TabAndroid* tab = reinterpret_cast<TabAndroid*>(tab_android_ptr);
 
@@ skipping 28 matching lines @@
   web_app_info.title =
       web_app_info.title.substr(0, chrome::kMaxMetaTagAttributeLength);
   web_app_info.description =
       web_app_info.description.substr(0, chrome::kMaxMetaTagAttributeLength);
 
   web_app_capable_ = web_app_info.mobile_capable;
 
   title_ = web_app_info.title.empty() ? web_contents()->GetTitle()
                                       : web_app_info.title;
 
+  web_contents()->GetManifest(base::Bind(&ShortcutHelper::OnDidGetManifest,
+                                         base::Unretained(this)));

[Miguel Garcia, 2014/09/17 09:02:42]

why base::unretained? wouldn't it be better to use a WeakPtrFactory?

[mlamouri (slow - plz ping), 2014/09/17 10:51:04]

Very good point. I wonder if I should introduce a way to cancel a Manifest
request. Anyhow, fixed with weak_ptr for now.

+}
+
+void ShortcutHelper::OnDidGetManifest(const content::Manifest& manifest) {
+  // Set the title based on the manifest value, if any.
+  if (!manifest.short_name.is_null())
+    title_ = manifest.short_name.string();
+  else if (!manifest.name.is_null())
+    title_ = manifest.name.string();
+
+  // Set the url based on the manifest value, if any.
+  if (manifest.start_url.is_valid())
+    url_ = manifest.start_url;
+
+  // The ShortcutHelper is now able to notify its Java counterpart that it is
+  // initialized. OnInitialized method is not conceptually part of getting the
+  // manifest data but it happens that the initialization is finalized when
+  // these data are available.
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
   ScopedJavaLocalRef<jstring> j_title =
       base::android::ConvertUTF16ToJavaString(env, title_);
 
   Java_ShortcutHelper_onInitialized(env, j_obj.obj(), j_title.obj());
 }
 
 void ShortcutHelper::TearDown(JNIEnv*, jobject) {
   Destroy();
@@ skipping 127 matching lines @@
           base::UserMetricsAction("webapps.AddShortcut.AppShortcutApple"));
       break;
     case WebApplicationInfo::MOBILE_CAPABLE_UNSPECIFIED:
       content::RecordAction(
           base::UserMetricsAction("webapps.AddShortcut.Bookmark"));
       break;
     default:
       NOTREACHED();
   }
 }