Use Web Manifest when creating a shortcut on Chrome Android.

chrome/browser/android/shortcut_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_helper.h"
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/location.h"
 #include "base/strings/string16.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "base/threading/worker_pool.h"
 #include "chrome/browser/android/tab_android.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/web_application_info.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/frame_navigate_params.h"
+#include "content/public/common/manifest.h"
 #include "jni/ShortcutHelper_jni.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/color_analysis.h"
 #include "ui/gfx/favicon_size.h"
 #include "url/gurl.h"
 
 jlong Initialize(JNIEnv* env, jobject obj, jlong tab_android_ptr) {
   TabAndroid* tab = reinterpret_cast<TabAndroid*>(tab_android_ptr);
 
   ShortcutHelper* shortcut_helper =
       new ShortcutHelper(env, obj, tab->web_contents());
   shortcut_helper->Initialize();
 
   return reinterpret_cast<intptr_t>(shortcut_helper);
 }
 
 ShortcutHelper::ShortcutHelper(JNIEnv* env,
                                jobject obj,
                                content::WebContents* web_contents)
     : WebContentsObserver(web_contents),
       java_ref_(env, obj),
       url_(web_contents->GetURL()),
       web_app_capable_(WebApplicationInfo::MOBILE_CAPABLE_UNSPECIFIED) {
 }
 
 void ShortcutHelper::Initialize() {
   // Send a message to the renderer to retrieve information about the page.
   Send(new ChromeViewMsg_GetWebApplicationInfo(routing_id()));

[Mike West, 2014/09/17 07:57:00]

Does the application info need to be gathered before you can execute
GetManifest? If not, perhaps you could run the two async requests in parallel,
similar to what we do in 'BrowsingDataRemover::AllDone'.

[mlamouri (slow - plz ping), 2014/09/17 08:47:11]

We probably could. We want to make sure the manifest values overwrite whatever
we have from the meta tags and the meta tags overwrite whatever we got from the
WebContents but that should not be a big issue. This said, it would likely make
the code harder to read and I'm not certain it's worth it. Getting the
WebAppInformation is a basic bounce to the renderer process. Surely, those two
IPC messages could take a while but more than likely insignificant compared to
the Manifest work.

Though, there are a lot of improvement we could do with regards to the async
work (and the UI that comes with it). I will keep that in mind when I will
tackle that. Thanks for the pointer!

 }
 
 ShortcutHelper::~ShortcutHelper() {
 }
 
 void ShortcutHelper::OnDidGetWebApplicationInfo(
     const WebApplicationInfo& received_web_app_info) {
   // Sanitize received_web_app_info.
   WebApplicationInfo web_app_info = received_web_app_info;
   web_app_info.title =
       web_app_info.title.substr(0, chrome::kMaxMetaTagAttributeLength);
   web_app_info.description =
       web_app_info.description.substr(0, chrome::kMaxMetaTagAttributeLength);
 
   web_app_capable_ = web_app_info.mobile_capable;
 
   title_ = web_app_info.title.empty() ? web_contents()->GetTitle()
                                       : web_app_info.title;
 
+  web_contents()->GetManifest(base::Bind(&ShortcutHelper::OnDidGetManifest,
+                                         base::Unretained(this)));
+}
+
+void ShortcutHelper::OnDidGetManifest(const content::Manifest& manifest) {
+  if (!manifest.short_name.is_null())
+    title_ = manifest.short_name.string();
+  else if (!manifest.name.is_null())
+    title_ = manifest.name.string();
+
   JNIEnv* env = base::android::AttachCurrentThread();

[Mike West, 2014/09/17 07:57:00]

Nit: For clarity, I'd suggest breaking this block out into something like an
"OnInitialized" method in this class. It's not conceptually part of getting the
manifest data, it's just the finalization of the initialization work that you
happen to be able to do only after getting the manifest data.

[mlamouri (slow - plz ping), 2014/09/17 08:47:11]

Done.

   ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
   ScopedJavaLocalRef<jstring> j_title =
       base::android::ConvertUTF16ToJavaString(env, title_);
 
   Java_ShortcutHelper_onInitialized(env, j_obj.obj(), j_title.obj());
 }
 
 void ShortcutHelper::TearDown(JNIEnv*, jobject) {
   Destroy();
 }
@@ skipping 126 matching lines @@
           base::UserMetricsAction("webapps.AddShortcut.AppShortcutApple"));
       break;
     case WebApplicationInfo::MOBILE_CAPABLE_UNSPECIFIED:
       content::RecordAction(
           base::UserMetricsAction("webapps.AddShortcut.Bookmark"));
       break;
     default:
       NOTREACHED();
   }
 }