Add ContextualSearchParams constructor to be called when content is passed via HTTP header and not …

components/search_engines/template_url.h

Index: components/search_engines/template_url.h
diff --git a/components/search_engines/template_url.h b/components/search_engines/template_url.h
index a01a50e0a66248762b35734b822b357095bb06fe..e4e517afac9a97996d073ab90bdebd8cf2b0adc2 100644
--- a/components/search_engines/template_url.h
+++ b/components/search_engines/template_url.h
@@ -74,14 +74,12 @@ class TemplateURLRef {
 
     struct ContextualSearchParams {
       ContextualSearchParams();
-      // TODO(jeremycho): Delete constructor once Clank no longer depends on it.
+      // TODO(jeremycho): Remove base_page_url parameter once it is logged from
+      // the HTTP header.
       ContextualSearchParams(const int version,

[donnd, 2014/09/16 21:23:18]

I would add comments detailing what the difference between these two
constructors is.  Otherwise readers may just assume that one is a simplified
version of the other rather than having quite strict requirements.

[jeremycho, 2014/09/16 21:26:53]

Done.

-                             const size_t start,
-                             const size_t end,
-                             const std::string& selection,
-                             const std::string& content,
                              const std::string& base_page_url,
-                             const std::string& encoding);
+                             const bool resolve);
+      // TODO(jeremycho): Delete constructor once Clank no longer depends on it.
       ContextualSearchParams(const int version,
                              const size_t start,
                              const size_t end,