Add ContextualSearchParams constructor to be called when content is passed via HTTP header and not …

Add ContextualSearchParams constructor to be called when content is passed via HTTP header and not CGI params.

BUG=376007
Committed: https://crrev.com/1c24838a493a66f5a9909d905ec0c6c5ed1de010
Cr-Commit-Position: refs/heads/master@{#295204}

[jeremycho, 2014-09-16 21:01:25]

jeremycho@chromium.org changed reviewers:
+ donnd@chromium.org, pkasting@chromium.org

[jeremycho, 2014-09-16 21:01:26]

Ready for review, thanks!

[donnd, 2014-09-16 21:23:17]

donnd@google.com changed reviewers:
+ donnd@google.com

[donnd, 2014-09-16 21:23:18]

LGTM modulo these comments.

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
File components/search_engines/template_url.cc (left):

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
components/search_engines/template_url.cc:209: const std::string& selection,
Jeremy for logging please include the selection too and use it in the q= cgi
arg.

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
File components/search_engines/template_url.h (right):

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
components/search_engines/template_url.h:79: ContextualSearchParams(const int
version,
I would add comments detailing what the difference between these two
constructors is.  Otherwise readers may just assume that one is a simplified
version of the other rather than having quite strict requirements.

[Peter Kasting, 2014-09-16 21:26:50]

LGTM

[jeremycho, 2014-09-16 21:26:54]

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
File components/search_engines/template_url.cc (left):

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
components/search_engines/template_url.cc:209: const std::string& selection,
On 2014/09/16 21:23:18, Donn wrote:
> Jeremy for logging please include the selection too and use it in the q= cgi
> arg.

Done.

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
File components/search_engines/template_url.h (right):

https://codereview.chromium.org/573063002/diff/1/components/search_engines/te...
components/search_engines/template_url.h:79: ContextualSearchParams(const int
version,
On 2014/09/16 21:23:18, Donn wrote:
> I would add comments detailing what the difference between these two
> constructors is.  Otherwise readers may just assume that one is a simplified
> version of the other rather than having quite strict requirements.

Done.

[jeremycho, 2014-09-16 23:25:10]

The CQ bit was checked by jeremycho@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/573063002/40001

[commit-bot: I haz the power, 2014-09-17 01:13:29]

Committed patchset #3 (id:40001) as 51c52361ead95a3f228a26e9212c1617cba4350d

[commit-bot: I haz the power, 2014-09-17 01:14:14]

Patchset 3 (id:??) landed as
https://crrev.com/1c24838a493a66f5a9909d905ec0c6c5ed1de010
Cr-Commit-Position: refs/heads/master@{#295204}