Issue 573018: * Generate contexts involving extensions using partial snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 573018: * Generate contexts involving extensions using partial snapshots. (Closed)

Created:
10 years, 10 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/partial_snapshots/

Visibility:
Public.

Description

* Generate contexts involving extensions using partial snapshots. Committed: http://code.google.com/p/v8/source/detail?r=3805

Patch Set 1 #

Total comments: 4

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -146 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+26 lines, -28 lines	0 comments	Download
M	src/bootstrapper.h	View	1 chunk	+10 lines, -1 line	2 comments	Download
M	src/bootstrapper.cc	View	15 chunks	+52 lines, -40 lines	2 comments	Download
M	src/v8-counters.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-serialize.cc	View	4 chunks	+90 lines, -74 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 10 months ago (2010-02-05 08:57:09 UTC) #2

LGTM

http://codereview.chromium.org/573018/diff/1/6
File src/bootstrapper.cc (right):

http://codereview.chromium.org/573018/diff/1/6#newcode381
src/bootstrapper.cc:381: return active_ != 0 || Genesis::current() != NULL;
Can we get rid of the Genesis::current() check and make sure to use
BootStrapperActive always when bootstrapping?

http://codereview.chromium.org/573018/diff/1/6#newcode1267
src/bootstrapper.cc:1267: if (!Debug::Load())
Either make this a one-liner or use braces around the body.

http://codereview.chromium.org/573018/diff/1/5
File src/bootstrapper.h (right):

http://codereview.chromium.org/573018/diff/1/5#newcode83
src/bootstrapper.h:83: class BootstrapperActive {
You should add BASE_EMBEDDED here to make sure that this can only be stack
allocated.

http://codereview.chromium.org/573018/diff/1/5#newcode89
src/bootstrapper.h:89: static int active_;
The name 'active_' makes me think it should be a bool.  How about 'nesting_'?

Expand Messages | Collapse Messages