Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 573013002: Detect whether a PAC url is present on Android (Closed)

Created:
6 years, 3 months ago by xunjieli
Modified:
6 years, 3 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, sgurun-gerrit only
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Detect whether a PAC url is present on Android This CL detects whether a PAC url is set in Android's system settings. If there is a PAC url, use that PAC url to construct a ProxyConfig. BUG=372475 Committed: https://crrev.com/b50a78b4dabfffa36b1d847167458d4a961c29ca Cr-Commit-Position: refs/heads/master@{#295489}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed pac to uppercase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M net/android/java/src/org/chromium/net/ProxyChangeListener.java View 7 chunks +28 lines, -5 lines 0 comments Download
M net/proxy/proxy_config_service_android.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_android.cc View 3 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xunjieli
Hi Eric, I have divided up my previous CL. This new one only contains proxy ...
6 years, 3 months ago (2014-09-16 18:10:20 UTC) #2
eroman
lgtm https://codereview.chromium.org/573013002/diff/1/net/proxy/proxy_config_service_android.h File net/proxy/proxy_config_service_android.h (right): https://codereview.chromium.org/573013002/diff/1/net/proxy/proxy_config_service_android.h#newcode44 net/proxy/proxy_config_service_android.h:44: // The third argument indicates the pac url. ...
6 years, 3 months ago (2014-09-18 15:55:21 UTC) #3
xunjieli
Thanks Eric for the review! https://codereview.chromium.org/573013002/diff/1/net/proxy/proxy_config_service_android.h File net/proxy/proxy_config_service_android.h (right): https://codereview.chromium.org/573013002/diff/1/net/proxy/proxy_config_service_android.h#newcode44 net/proxy/proxy_config_service_android.h:44: // The third argument ...
6 years, 3 months ago (2014-09-18 16:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573013002/20001
6 years, 3 months ago (2014-09-18 16:19:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2a27a5906b85ef5d66b54cdbd370e98ae9572027
6 years, 3 months ago (2014-09-18 17:34:05 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:34:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b50a78b4dabfffa36b1d847167458d4a961c29ca
Cr-Commit-Position: refs/heads/master@{#295489}

Powered by Google App Engine
This is Rietveld 408576698