components/nacl/loader/nacl_validation_query.cc - Issue 572973002: NaCl: Simpler validation for main nexe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_validation_query.cc

Issue 572973002: NaCl: Simpler validation for main nexe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_validation_query.cc

diff --git a/components/nacl/loader/nacl_validation_query.cc b/components/nacl/loader/nacl_validation_query.cc

index ecedbcaa9f49681a39618741cfea0e238b4d40c5..0a3582e9dd9147e6c57bef23582b39c32d9dd683 100644

--- a/components/nacl/loader/nacl_validation_query.cc

+++ b/components/nacl/loader/nacl_validation_query.cc

@@ -35,7 +35,9 @@ bool NaClValidationQueryContext::ResolveFileToken(

struct NaClFileToken* file_token,

int32* fd,

std::string* path) {

- return db_->ResolveFileToken(file_token, fd, path);

+ // This should no longer be used.

+ CHECK(false);

+ return false;

}

NaClValidationQuery::NaClValidationQuery(NaClValidationDB* db,