components/nacl/loader/nonsfi/nonsfi_listener.cc - Issue 572973002: NaCl: Simpler validation for main nexe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nonsfi/nonsfi_listener.cc

Issue 572973002: NaCl: Simpler validation for main nexe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Let NaCl code do file path fallback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nonsfi/nonsfi_listener.cc

diff --git a/components/nacl/loader/nonsfi/nonsfi_listener.cc b/components/nacl/loader/nonsfi/nonsfi_listener.cc

index cd1aac300a1db4ecf3bdddea8c5b77644b5eef09..b4b9d0c95f0dc64b71f35148c992299f00a236db 100644

--- a/components/nacl/loader/nonsfi/nonsfi_listener.cc

+++ b/components/nacl/loader/nonsfi/nonsfi_listener.cc

@@ -144,8 +144,6 @@ void NonSfiListener::OnStart(const nacl::NaClStartParams& params) {

CHECK(params.process_type == kNativeNaClProcessType);

CHECK(params.nexe_file != IPC::InvalidPlatformFileForTransit());

- CHECK(params.nexe_token_lo == 0);

Mark Seaborn 2014/10/16 18:01:01 Shouldn't this check nexe_file_path_metadata is em

teravest 2014/10/16 21:40:40 Done.

- CHECK(params.nexe_token_hi == 0);

MainStart(IPC::PlatformFileForTransitToPlatformFile(params.nexe_file));

}